Skip to content

*: use global stats & make ddl/feedback/show/export works(part III)#20271

Merged
ti-srebot merged 4 commits intopingcap:masterfrom
lysu:dev-split-feedback-show
Oct 14, 2020
Merged

*: use global stats & make ddl/feedback/show/export works(part III)#20271
ti-srebot merged 4 commits intopingcap:masterfrom
lysu:dev-split-feedback-show

Conversation

@lysu
Copy link
Contributor

@lysu lysu commented Sep 28, 2020

What problem does this PR solve?

Problem Summary:

the last of Split PRs for #18717

full test will added by #20301

What is changed and how it works?

What's Changed, How it Works:

In this PR, we will:

  • make planner use global stats under Dynamic-Only mode
  • make feedback works
  • make ddl create/truncate operation init stats meta
  • make show stats_* works to observe stats data
  • also make export/import stats works
  • at last it add check before set prune mode to Dynamic-Only

Related changes

  • n/a

Check List

Tests

  • Unit test
  • Integration test
  • WIP

Side effects

  • n/a

Release note

  • No release note

This change is Reviewable

@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Sep 28, 2020
@lysu
Copy link
Contributor Author

lysu commented Sep 28, 2020

/run-all-tests

@lysu lysu changed the title *: use global stats & make ddl/feedback/show/export works *: use global stats & make ddl/feedback/show/export works(part III) Sep 29, 2020
@lysu
Copy link
Contributor Author

lysu commented Oct 9, 2020

/run-all-tests

1 similar comment
@lysu
Copy link
Contributor Author

lysu commented Oct 9, 2020

/run-all-tests

@lysu lysu marked this pull request as ready for review October 9, 2020 05:58
@lysu lysu requested review from a team as code owners October 9, 2020 05:58
@lysu lysu requested review from XuHuaiyu and removed request for a team October 9, 2020 05:58
@lysu lysu marked this pull request as draft October 9, 2020 05:58
@lysu lysu marked this pull request as ready for review October 9, 2020 06:01
@lysu lysu requested review from imtbkcat and tiancaiamao October 9, 2020 06:01
@lysu lysu marked this pull request as draft October 9, 2020 06:01
@lysu lysu added status/WIP and removed status/WIP labels Oct 9, 2020
@lysu lysu marked this pull request as ready for review October 9, 2020 11:39
@lysu
Copy link
Contributor Author

lysu commented Oct 12, 2020

/run-build-image

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2020
@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 14, 2020
@tiancaiamao
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants