Skip to content

*: collect multiple partitions and store in tidb (part II)#19899

Merged
ti-srebot merged 4 commits intopingcap:masterfrom
lysu:dev-anlayze-multi-part-one-req
Sep 29, 2020
Merged

*: collect multiple partitions and store in tidb (part II)#19899
ti-srebot merged 4 commits intopingcap:masterfrom
lysu:dev-anlayze-multi-part-one-req

Conversation

@lysu
Copy link
Contributor

@lysu lysu commented Sep 9, 2020

What problem does this PR solve?

Problem Summary:

one of Split PRs for #18717

What is changed and how it works?

In this PR we:

  • build analyze task that "collect multi partitions and save as a table" or "collect a partition save a partition" or "both" in planner/core/planbuilder.go
  • build analyze request that can analyze multi tables(i.e. partitions) as one request in executor/analyze.go
  • for local non-unique index use "fast analyze index" in executor/builder.go, also support sample multi tables in buildSampTask
  • fix for test case, now we pass test with static-only mode(old), next prs will add more mix or dynamic mode test

Next PR will:

Related changes

  • n/a

Check List

Tests

  • Unit test

Side effects

  • n/a

Release note

  • No release note

This change is Reviewable

@github-actions github-actions bot added the sig/execution SIG execution label Sep 9, 2020
@pingcap pingcap deleted a comment from lilinghai Sep 27, 2020
@pingcap pingcap deleted a comment from lilinghai Sep 27, 2020
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Sep 27, 2020
@lysu lysu marked this pull request as ready for review September 27, 2020 13:02
@lysu lysu requested review from a team as code owners September 27, 2020 13:02
@lysu lysu requested review from lzmhhh123 and removed request for a team September 27, 2020 13:02
@lysu
Copy link
Contributor Author

lysu commented Sep 27, 2020

/run-all-tests

@lysu lysu changed the title *: analyze multi-partition with one analyze req *: collect multiple partitions and store in tidb (part II) Sep 27, 2020
@lysu
Copy link
Contributor Author

lysu commented Sep 28, 2020

@imtbkcat @tiancaiamao please help take look and I will prepare following PRs soon, thx :D

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2020
@lysu
Copy link
Contributor Author

lysu commented Sep 29, 2020

@winoros @tiancaiamao PTAL if free thx

@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 29, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 29, 2020
@tiancaiamao
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 29, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 170e2fe into pingcap:master Sep 29, 2020
@lysu lysu deleted the dev-anlayze-multi-part-one-req branch September 30, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants