Skip to content

CircleCI: upgrade go version from 1.13 to 1.15#19170

Merged
ngaut merged 5 commits intomasterfrom
upgrade-go-compiler
Feb 9, 2021
Merged

CircleCI: upgrade go version from 1.13 to 1.15#19170
ngaut merged 5 commits intomasterfrom
upgrade-go-compiler

Conversation

@ngaut
Copy link
Member

@ngaut ngaut commented Aug 13, 2020

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2020
@ngaut
Copy link
Member Author

ngaut commented Aug 13, 2020

/run-all-tests

@zz-jason
Copy link
Member

zz-jason commented Feb 9, 2021

@zhouqiang-cl PTAL

@sre-bot
Copy link
Contributor

sre-bot commented Feb 9, 2021

@zz-jason
Copy link
Member

zz-jason commented Feb 9, 2021

/rebuild

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 9, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 9, 2021
@zz-jason
Copy link
Member

zz-jason commented Feb 9, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@ngaut merge failed.

@ngaut ngaut merged commit 4a6e739 into master Feb 9, 2021
@ngaut ngaut deleted the upgrade-go-compiler branch February 9, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants