Skip to content

*: handle signed/unsigned in the partition pruning (#15436)#17230

Merged
sre-bot merged 4 commits intopingcap:release-4.0from
tiancaiamao:cherry-15436-performance
May 20, 2020
Merged

*: handle signed/unsigned in the partition pruning (#15436)#17230
sre-bot merged 4 commits intopingcap:release-4.0from
tiancaiamao:cherry-15436-performance

Conversation

@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented May 15, 2020 •
edited
Loading

Cherry pick from #15436

This one also fix a serious performance problem on range column partition.

Release note

  • Fix a bug signed/unsigned integer is not distinguished during the partition pruning, and also optimize performance for some cases.

@tiancaiamao tiancaiamao requested review from a team as code owners May 15, 2020 05:00
@ghost ghost requested review from XuHuaiyu and francis0407 and removed request for a team May 15, 2020 05:01
@sre-bot
Copy link
Contributor

sre-bot commented May 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@tiancaiamao tiancaiamao requested review from imtbkcat and lysu and removed request for XuHuaiyu and francis0407 May 15, 2020 05:04
@tiancaiamao tiancaiamao added the type/bugfix This PR fixes a bug. label May 15, 2020
@tiancaiamao tiancaiamao added this to the v4.0.0-ga milestone May 15, 2020
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented May 15, 2020

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented May 15, 2020

/rebuild

1 similar comment
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented May 15, 2020

/rebuild

@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented May 18, 2020

/run-all-tests

@lysu
Copy link
Contributor

lysu commented May 18, 2020

/rebuild

lysu
lysu reviewed May 18, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT1 Indicates that a PR has LGTM 1. status/PTAL labels May 18, 2020
imtbkcat
imtbkcat approved these changes May 18, 2020
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

@lysu, @imtbkcat, PTAL.

jackysp
jackysp reviewed May 20, 2020
View reviewed changes
Copy link
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jebter
Copy link

jebter commented May 20, 2020

/run-unit-test

@jebter
Copy link

jebter commented May 20, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit 149dd0d into pingcap:release-4.0 May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackysp jackysp jackysp left review comments

+2 more reviewers

@lysu lysu lysu left review comments

@imtbkcat imtbkcat imtbkcat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/performance type/4.0-cherry-pick

Projects

None yet

Milestone

v4.0.0-ga

Development

Successfully merging this pull request may close these issues.

6 participants

@tiancaiamao @sre-bot @lysu @jebter @jackysp @imtbkcat