Skip to content

server: fix SIGSEGV caused by port probing with audit plugin (#16038)#16064

Merged
sre-bot merged 2 commits intopingcap:release-3.0from
sre-bot:release-3.0-6d02bc72d9c0
Apr 7, 2020
Merged

server: fix SIGSEGV caused by port probing with audit plugin (#16038)#16064
sre-bot merged 2 commits intopingcap:release-3.0from
sre-bot:release-3.0-6d02bc72d9c0

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 3, 2020

cherry-pick #16038 to release-3.0


What problem does this PR solve?

Issue Number: close #16037

Problem Summary:

port probing will establish tcp connection, then exit without send any auth packet, so conn's session ctx should be nil and this cause crash in audit plugin code path.

What is changed and how it works?

What's Changed:

ensure session ctx is not nil before do reject audit.

How it Works:

check nil

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test
start tidb with audit plugin, and telnet 0.0.0.0 4000 then control-c to exit telent

and watch tidb-stderr.log

Side effects

  • n/a

Release note


This change is Reviewable

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Apr 3, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 3, 2020

/run-all-tests

Copy link
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor

lysu commented Apr 3, 2020

/run-unit-test

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 5, 2020

@jackysp, @imtbkcat, PTAL.

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu self-assigned this Apr 7, 2020
@jackysp
Copy link
Contributor

jackysp commented Apr 7, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 7, 2020

/run-all-tests

@sre-bot sre-bot merged commit 0119b17 into pingcap:release-3.0 Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/plugin component/server contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/3.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants