Skip to content

server, session: refine mysql handshake error log (#15731)#15799

Merged
sre-bot merged 5 commits intopingcap:release-3.1from
sre-bot:release-3.1-e42c82597982
Apr 7, 2020
Merged

server, session: refine mysql handshake error log (#15731)#15799
sre-bot merged 5 commits intopingcap:release-3.1from
sre-bot:release-3.1-e42c82597982

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 28, 2020

cherry-pick #15731 to release-3.1


What problem does this PR solve?

Problem Summary:

now, we log out too many EOF log due to port health check

What is changed and how it works?

make handshake EOF error be logged as INFO level(or debug?) and suspend stack info for them

What's Changed:

How it Works:

log inside handshake method

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test

Side effects

  • n/a

Release note

refine mysql mysql handshake error log


This change is Reviewable

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 28, 2020

/run-all-tests

@lysu
Copy link
Contributor

lysu commented Mar 30, 2020

/run-all-tests

Copy link
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Contributor

jackysp commented Apr 7, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 7, 2020

Your auto merge job has been accepted, waiting for 15818

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 7, 2020

/run-all-tests

@sre-bot sre-bot merged commit ee210d3 into pingcap:release-3.1 Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants