planner,expression,table: clean up the old partition pruning code#14834
Merged
tiancaiamao merged 12 commits intopingcap:masterfrom Feb 26, 2020
Merged
planner,expression,table: clean up the old partition pruning code#14834tiancaiamao merged 12 commits intopingcap:masterfrom
tiancaiamao merged 12 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
PTAL @imtbkcat |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/rebuild |
Contributor
Author
imtbkcat
reviewed
Feb 19, 2020
| ] | ||
| }, | ||
| { | ||
| "SQL": "explain select * from t1 where t1.a > 7 and t1.a < 3", |
Contributor
Author
There was a problem hiding this comment.
Because I remove constraint propagate solver, now a > 7 and a < 3 can't be solved.
This plan now change to union all partitions.
I guess it's acceptable: our user should be clever enough and not writing this kind of silly queries.
Codecov Report
@@ Coverage Diff @@
## master #14834 +/- ##
===========================================
Coverage 80.7188% 80.7188%
===========================================
Files 503 503
Lines 133493 133493
===========================================
Hits 107754 107754
Misses 17404 17404
Partials 8335 8335 |
Contributor
|
/run-all-tests |
Contributor
|
@tiancaiamao merge failed. |
Contributor
Author
|
/run-all-tests |
|
/run-all-tests |
This was referenced Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Clean up unused code after #14679
What is changed and how it works?
PartitionExpr.Rangesare not usedI also remove a test case as it can't be pruned anymore without constraint propagator:
Check List
Tests
Code changes