Skip to content

executor: reuse chunk row for insert on duplicate update (#12847)#13000

Merged
sre-bot merged 2 commits intopingcap:release-3.1from
jackysp:reuse_insert_chunk_3.1
Nov 5, 2019
Merged

executor: reuse chunk row for insert on duplicate update (#12847)#13000
sre-bot merged 2 commits intopingcap:release-3.1from
jackysp:reuse_insert_chunk_3.1

Conversation

@jackysp
Copy link
Contributor

@jackysp jackysp commented Oct 29, 2019

Conflicts:
executor/insert.go
expression/column.go

What problem does this PR solve?

Cherry pick #12847 to release 3.1.

Conflicts:
executor/insert.go
expression/column.go
@jackysp
Copy link
Contributor Author

jackysp commented Oct 30, 2019

/rebuild

@jackysp
Copy link
Contributor Author

jackysp commented Nov 1, 2019

PTAL @lysu @coocood

@coocood
Copy link
Member

coocood commented Nov 1, 2019

LGTM

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 4, 2019
@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit bc81299 into pingcap:release-3.1 Nov 5, 2019
@jackysp jackysp deleted the reuse_insert_chunk_3.1 branch February 27, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants