Skip to content

executor: reuse chunk row for insert on duplicate update (#12847)#12998

Merged
sre-bot merged 2 commits intopingcap:release-3.0from
jackysp:reuse_insert_chunk_3.0
Nov 5, 2019
Merged

executor: reuse chunk row for insert on duplicate update (#12847)#12998
sre-bot merged 2 commits intopingcap:release-3.0from
jackysp:reuse_insert_chunk_3.0

Conversation

@jackysp
Copy link
Contributor

@jackysp jackysp commented Oct 29, 2019

What problem does this PR solve?

Cherry-pick #12847 to release 3.0.

Confilict files:

expression/column.go

executor/insert.go

@jackysp jackysp added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution type/2.1 cherry-pick and removed type/2.1 cherry-pick labels Oct 29, 2019
@lysu
Copy link
Contributor

lysu commented Oct 29, 2019

/rebuild

@jackysp jackysp requested review from coocood and lysu October 30, 2019 02:10
@jackysp
Copy link
Contributor Author

jackysp commented Nov 1, 2019

PTAL @coocood @lysu

@coocood
Copy link
Member

coocood commented Nov 1, 2019

LGTM

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 4, 2019
@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 5, 2019

Your auto merge job has been accepted, waiting for 13000, 12999

@sre-bot
Copy link
Contributor

sre-bot commented Nov 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit cdcb4ae into pingcap:release-3.0 Nov 5, 2019
@jackysp jackysp deleted the reuse_insert_chunk_3.0 branch February 27, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants