Skip to content

planner, executor: support create view on union (#12595)#12956

Merged
zz-jason merged 4 commits intopingcap:release-3.1from
XuHuaiyu:release-3.1
Oct 28, 2019
Merged

planner, executor: support create view on union (#12595)#12956
zz-jason merged 4 commits intopingcap:release-3.1from
XuHuaiyu:release-3.1

Conversation

@XuHuaiyu
Copy link
Contributor

cherry-pick #12595

What problem does this PR solve?

  1. support create view on union
  2. refine the error message to make it more compatible with MySQL

What is changed and how it works?

  1. change go.mod
  2. reset the error to ErrViewInvalid when buildViewFromDatasource raises an error during building the logical plan

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

Release note

[bug-fix] Support create view on a union statement. Creating view on a union statement will cause a syntax error before.

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway
Copy link
Contributor

Please fix the build.

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

PTAL @SunRunAway

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 28, 2019
@zz-jason zz-jason merged commit 8db3848 into pingcap:release-3.1 Oct 28, 2019
@XuHuaiyu XuHuaiyu deleted the release-3.1 branch October 28, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/test sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants