Skip to content

planner: unfold the wildcard when creating view (#11818)#12936

Merged
ngaut merged 2 commits intopingcap:release-3.1from
XuHuaiyu:release-3.1
Oct 28, 2019
Merged

planner: unfold the wildcard when creating view (#11818)#12936
ngaut merged 2 commits intopingcap:release-3.1from
XuHuaiyu:release-3.1

Conversation

@XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Oct 25, 2019

cherry-pick #11818

conflict files: planner/core/logical_plan_builder.go

What problem does this PR solve?

As part of View implement, remove view's wildcard and expand it.

What is changed and how it works?

ref proposal Proposal: Implement View

Check List

Tests

  • Unit test

Description

Let's take a example with create view,

CREATE VIEW V AS SELECT *FROM mysql.tidb

Before this PR,View will store select statement like

SELECT * FROM mysql.tidb

After this PR, View will store select statement like

SELECT VARIABLE_NAME,VARIABLE_VALUE,COMMENT FROM mysql.tidb

@XuHuaiyu XuHuaiyu added type/enhancement The issue or PR belongs to an enhancement. type/3.1 cherry-pick labels Oct 25, 2019
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=pr/930

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

/run-all-tests

1 similar comment
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@ngaut ngaut removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

@XuHuaiyu merge failed.

@XuHuaiyu
Copy link
Contributor Author

/rebuild

@ngaut ngaut merged commit d5e52b4 into pingcap:release-3.1 Oct 28, 2019
@XuHuaiyu XuHuaiyu deleted the release-3.1 branch October 28, 2019 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants