Skip to content

planner: unfold the wildcard when creating view (#11818)#12912

Merged
sre-bot merged 3 commits intopingcap:release-3.0from
XuHuaiyu:release-3.0
Oct 28, 2019
Merged

planner: unfold the wildcard when creating view (#11818)#12912
sre-bot merged 3 commits intopingcap:release-3.0from
XuHuaiyu:release-3.0

Conversation

@XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Oct 24, 2019

cherry-pick #11818

conflict files: planner/core/logical_plan_builder.go

What problem does this PR solve?

As part of View implement, remove view's wildcard and expand it.

What is changed and how it works?

ref proposal Proposal: Implement View

Check List

Tests

  • Unit test

Description

Let's take a example with create view,

CREATE VIEW V AS SELECT *FROM mysql.tidb

Before this PR,View will store select statement like

SELECT * FROM mysql.tidb

After this PR, View will store select statement like

SELECT VARIABLE_NAME,VARIABLE_VALUE,COMMENT FROM mysql.tidb

@XuHuaiyu XuHuaiyu added needs-cherry-pick-3.0 type/enhancement The issue or PR belongs to an enhancement. labels Oct 24, 2019
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

/run-common-test tidb-test=pr/930
/run-integration-common-test tidb-test=pr/930

1 similar comment
@XuHuaiyu
Copy link
Contributor Author

/run-common-test tidb-test=pr/930
/run-integration-common-test tidb-test=pr/930

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=pr/930

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

Your auto merge job has been accepted, waiting for 12936

@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

/run-all-tests

@sre-bot sre-bot merged commit 1019012 into pingcap:release-3.0 Oct 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2019

cherry pick to release-3.0 failed

@XuHuaiyu XuHuaiyu deleted the release-3.0 branch October 28, 2019 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants