Skip to content

expression: fix incorrect result of logical operators (#12173)#12811

Merged
eurekaka merged 7 commits intopingcap:release-3.0from
SunRunAway:automated-cherry-pick-of-#12173-upstream-release-3.0
Oct 18, 2019
Merged

expression: fix incorrect result of logical operators (#12173)#12811
eurekaka merged 7 commits intopingcap:release-3.0from
SunRunAway:automated-cherry-pick-of-#12173-upstream-release-3.0

Conversation

@SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Oct 18, 2019 •
edited
Loading

Automated cherry pick of #12173 on release-3.0.

What problem does this PR solve?

Fix issue #11199

TiDB> SELECT NULL OR 0.00000001000000000000;
+--------------------------------+
| NULL OR 0.00000001000000000000 |
+--------------------------------+
|                              1 |
+--------------------------------+
1 row in set (0.00 sec)

TiDB> SELECT 0 OR 0.00000001000000000000;
+-----------------------------+
| 0 OR 0.00000001000000000000 |
+-----------------------------+
|                           1 |
+-----------------------------+
1 row in set (0.00 sec)

TiDB> SELECT 0 OR "0.01a";
+--------------+
| 0 OR "0.01a" |
+--------------+
|            1 |
+--------------+
1 row in set, 1 warning (0.00 sec)

What is changed and how it works?

Wrap the input parameters of the builtin AND、OR and XOR operators with IS TRUE function before cast them to int type.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

  • fix incorrect result of logical operators (OR, AND)

@SunRunAway SunRunAway force-pushed the automated-cherry-pick-of-#12173-upstream-release-3.0 branch from 152f3c4 to 8096263 Compare October 18, 2019 07:19
@SunRunAway
Copy link
Contributor Author

SunRunAway commented Oct 18, 2019

/run-all-tests

@SunRunAway SunRunAway requested review from XuHuaiyu, eurekaka, qw4990 and zz-jason and removed request for zz-jason October 18, 2019 07:40
XuHuaiyu
XuHuaiyu reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Oct 18, 2019
@zimulala zimulala added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. labels Oct 18, 2019
eurekaka
eurekaka approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka merged commit 93f8151 into pingcap:release-3.0 Oct 18, 2019
@SunRunAway SunRunAway deleted the automated-cherry-pick-of-#12173-upstream-release-3.0 branch October 18, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@eurekaka eurekaka eurekaka approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees

No one assigned

Labels

component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SunRunAway @eurekaka @XuHuaiyu @zimulala