planner: stream agg should not be pushed to double read (#12443)#12690
Merged
eurekaka merged 3 commits intopingcap:release-3.0from Oct 28, 2019
Merged
planner: stream agg should not be pushed to double read (#12443)#12690eurekaka merged 3 commits intopingcap:release-3.0from
eurekaka merged 3 commits intopingcap:release-3.0from
Conversation
For the following two reason, we should not push stream agg down to double read - The aggregate will lost the handle information - There's no sort operator. The second read is ordered with pk, not by index.
Member
|
LGTM |
Contributor
|
/run-all-tests |
Member
|
Still not merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #12443
There's a question that 3.0 has not
STREAM_AGG()hint. It's hard to add a test to test the stream agg must fail though we force to choose it.