Skip to content

server: fix wrong deletion introduced by #12454#12495

Merged
lonng merged 1 commit intopingcap:masterfrom
lonng:fix-wrong-deletion
Sep 30, 2019
Merged

server: fix wrong deletion introduced by #12454#12495
lonng merged 1 commit intopingcap:masterfrom
lonng:fix-wrong-deletion

Conversation

@lonng
Copy link
Contributor

@lonng lonng commented Sep 30, 2019

Signed-off-by: Lonng heng@lonng.org

What problem does this PR solve?

The #12454 inadvertently deleted a line:
See: https://github.com/pingcap/tidb/pull/12454/files#diff-dc417f5322100e2e83a8818c70a25878L178

What is changed and how it works?

Revert this change.

Check List

Tests

  • Unit test

Release note

  • No need to add to release note.

Signed-off-by: Lonng <heng@lonng.org>
@cfzjywxk
Copy link
Contributor

LGTM

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1a9fcb9). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             master    #12495   +/-   ##
==========================================
  Coverage          ?   79.809%           
==========================================
  Files             ?       460           
  Lines             ?    102249           
  Branches          ?         0           
==========================================
  Hits              ?     81604           
  Misses            ?     14749           
  Partials          ?      5896

@lonng lonng added status/can-merge Indicates a PR has been approved by a committer. component/server labels Sep 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 30, 2019

/run-all-tests

@lonng lonng merged commit a3d4f89 into pingcap:master Sep 30, 2019
@lonng lonng deleted the fix-wrong-deletion branch September 30, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/server status/can-merge Indicates a PR has been approved by a committer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants