Skip to content

ddl: allow multiple unique attributes in a column (#12165)#12464

Merged
ngaut merged 7 commits intopingcap:release-3.1from
sre-bot:release-3.1-0ee738bb9463
Oct 10, 2019
Merged

ddl: allow multiple unique attributes in a column (#12165)#12464
ngaut merged 7 commits intopingcap:release-3.1from
sre-bot:release-3.1-0ee738bb9463

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 28, 2019

cherry-pick #12165 to release-3.1


What problem does this PR solve?

Fix #12006.

What is changed and how it works?

Remove constraint name assignment when building ast.Constraint from Option of ast.ColumnDef. Let checkConstraintNames determine the name later to avoid the name duplication.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Allow multiple unique attributes in a column

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 28, 2019

/run-all-tests

@tangenta
Copy link
Contributor

/run-unit-test
/run-build_check_race
/rebuild

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Oct 3, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 3, 2019

Your auto merge job has been accepted, waiting for 12469

@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 3, 2019

/run-all-tests

@ngaut ngaut merged commit cbf19c3 into pingcap:release-3.1 Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants