Skip to content

expression: implement vectorized evaluation for builtinCeilIntToIntSig#12459

Merged
qw4990 merged 3 commits intopingcap:masterfrom
tangwz:fix_builtinCeilIntToIntSig
Sep 29, 2019
Merged

expression: implement vectorized evaluation for builtinCeilIntToIntSig#12459
qw4990 merged 3 commits intopingcap:masterfrom
tangwz:fix_builtinCeilIntToIntSig

Conversation

@tangwz
Copy link
Contributor

@tangwz tangwz commented Sep 28, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinCeilIntToIntSig.
Issue: #12103

What is changed and how it works?

BenchmarkVectorizedBuiltinMathFunc/builtinCeilIntToIntSig-VecBuiltinFunc-4                      20000000               103 ns/op               0 B/op            0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinCeilIntToIntSig-NonVecBuiltinFunc-4                     100000             19115 ns/op               0 B/op            0 allocs/op

Check List

Tests

  • Unit test
  • Integration test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 28, 2019
@codecov
Copy link

codecov bot commented Sep 28, 2019

Codecov Report

Merging #12459 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12459   +/-   ##
===========================================
  Coverage   79.8418%   79.8418%           
===========================================
  Files           462        462           
  Lines        102301     102301           
===========================================
  Hits          81679      81679           
  Misses        14742      14742           
  Partials       5880       5880

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/expression status/LGT1 Indicates that a PR has LGTM 1. labels Sep 29, 2019
@zz-jason zz-jason requested a review from qw4990 September 29, 2019 01:42
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2019

@tangwz merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Sep 29, 2019

/run-check_dev

@qw4990
Copy link
Contributor

qw4990 commented Sep 29, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Sep 29, 2019

/rebuild

@qw4990 qw4990 merged commit 183d5b1 into pingcap:master Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants