Skip to content

expression: implement vectorized evaluation for builtinNullEQRealSig#12455

Merged
qw4990 merged 4 commits intopingcap:masterfrom
PiotrNewt:vecexpr-func-NullEQReal
Sep 29, 2019
Merged

expression: implement vectorized evaluation for builtinNullEQRealSig#12455
qw4990 merged 4 commits intopingcap:masterfrom
PiotrNewt:vecexpr-func-NullEQReal

Conversation

@PiotrNewt
Copy link
Contributor

What problem does this PR solve?

Implement vectorized evaluation for builtinNullEQRealSig, for issue #12103

What is changed and how it works?

  • Implement vectorized evaluation.

Here is the benchmark , almost 7x faster than before:

BenchmarkVectorizedBuiltinCompareFunc/builtinNullEQRealSig-VecBuiltinFunc-4         	  284035	      3989 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinCompareFunc/builtinNullEQRealSig-NonVecBuiltinFunc-4      	   39982	     29278 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 28, 2019
@codecov
Copy link

codecov bot commented Sep 28, 2019

Codecov Report

Merging #12455 into master will decrease coverage by 0.0315%.
The diff coverage is 65.5172%.

@@               Coverage Diff               @@
##            master     #12455        +/-   ##
===============================================
- Coverage   79.814%   79.7824%   -0.0316%     
===============================================
  Files          462        462                
  Lines       102274     102139       -135     
===============================================
- Hits         81629      81489       -140     
- Misses       14764      14775        +11     
+ Partials      5881       5875         -6

@zz-jason zz-jason requested a review from qw4990 September 28, 2019 11:45
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/expression status/LGT1 Indicates that a PR has LGTM 1. labels Sep 28, 2019
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2019

@PiotrNewt merge failed.

@PiotrNewt PiotrNewt requested a review from qw4990 September 29, 2019 06:33
@qw4990 qw4990 merged commit cda5d35 into pingcap:master Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants