Skip to content

expression: implement vectorized evaluation for 'builtinUnHexSig'#12433

Merged
qw4990 merged 7 commits intopingcap:masterfrom
tsthght:builtinUnHexSig
Sep 29, 2019
Merged

expression: implement vectorized evaluation for 'builtinUnHexSig'#12433
qw4990 merged 7 commits intopingcap:masterfrom
tsthght:builtinUnHexSig

Conversation

@tsthght
Copy link
Contributor

@tsthght tsthght commented Sep 27, 2019 •
edited by qw4990
Loading

What problem does this PR solve?

Implement vectorized evaluation for builtinUnHexSig, for #12106

What is changed and how it works?

BenchmarkVectorizedBuiltinStringFunc/builtinUnHexSig-VecBuiltinFunc-8         	    3000	    465516 ns/op	  104624 B/op	    1544 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinUnHexSig-NonVecBuiltinFunc-8      	    3000	    497644 ns/op	  123408 B/op	    2302 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 27, 2019
@tsthght
Copy link
Contributor Author

tsthght commented Sep 27, 2019

/rebuild

@qw4990 qw4990 requested review from SunRunAway and qw4990 September 27, 2019 05:55
@qw4990
Copy link
Contributor

qw4990 commented Sep 27, 2019 

[2019-09-27T04:10:58.088Z] gofmt (simplify)
[2019-09-27T04:11:02.259Z] expression/builtin_string_vec_test.go
[2019-09-27T04:11:02.259Z] make: *** [fmt] Error 1

Please format builtin_string_vec_test.go to pass CI tests. @tsthght

@tsthght
Copy link
Contributor Author

tsthght commented Sep 27, 2019

/rebuild

@qw4990
Copy link
Contributor

qw4990 commented Sep 27, 2019

/run-unit-test

@qw4990
Copy link
Contributor

qw4990 commented Sep 27, 2019

/run-check_dev_2

qw4990
qw4990 reviewed Sep 27, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #12433 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12433   +/-   ##
===========================================
  Coverage   79.8605%   79.8605%           
===========================================
  Files           462        462           
  Lines        102431     102431           
===========================================
  Hits          81802      81802           
  Misses        14737      14737           
  Partials       5892       5892

@qw4990 qw4990 requested a review from zz-jason September 28, 2019 10:14
zz-jason
zz-jason reviewed Sep 28, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2019
@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2019

/run-all-tests

@qw4990 qw4990 merged commit 1b03d16 into pingcap:master Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zz-jason zz-jason zz-jason left review comments

@qw4990 qw4990 qw4990 approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees

No one assigned

Labels

component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tsthght @qw4990 @sre-bot @zz-jason