Skip to content

expression: implement vectorized evaluation for 'builtinOctIntSig'#12429

Merged
qw4990 merged 5 commits intopingcap:masterfrom
tsthght:builtinOctIntSig
Sep 27, 2019
Merged

expression: implement vectorized evaluation for 'builtinOctIntSig'#12429
qw4990 merged 5 commits intopingcap:masterfrom
tsthght:builtinOctIntSig

Conversation

@tsthght
Copy link
Contributor

@tsthght tsthght commented Sep 26, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinOctIntSig, for #12106

What is changed and how it works?

BenchmarkVectorizedBuiltinStringFunc/builtinOctIntSig-VecBuiltinFunc-8         	   20000	     64667 ns/op	   25568 B/op	     799 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinOctIntSig-NonVecBuiltinFunc-8      	   20000	     77762 ns/op	   25568 B/op	     799 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 26, 2019
@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #12429 into master will increase coverage by 0.0176%.
The diff coverage is 75%.

@@               Coverage Diff                @@
##             master     #12429        +/-   ##
================================================
+ Coverage   79.7292%   79.7469%   +0.0176%     
================================================
  Files           462        462                
  Lines        101935     101935                
================================================
+ Hits          81272      81290        +18     
+ Misses        14787      14772        -15     
+ Partials       5876       5873         -3

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tsthght Please resolve conflicts.

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 27, 2019

/run-all-tests

@qw4990 qw4990 merged commit cf13e0d into pingcap:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants