Skip to content

expression: implement vectorized evaluation for 'builtinBinSig'#12427

Merged
sre-bot merged 3 commits intopingcap:masterfrom
tsthght:builtinBinSig
Sep 27, 2019
Merged

expression: implement vectorized evaluation for 'builtinBinSig'#12427
sre-bot merged 3 commits intopingcap:masterfrom
tsthght:builtinBinSig

Conversation

@tsthght
Copy link
Contributor

@tsthght tsthght commented Sep 26, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinBinSig, for #12106

What is changed and how it works?

BenchmarkVectorizedBuiltinStringFunc/builtinBinSig-VecBuiltinFunc-8         	   10000	    158827 ns/op	   59789 B/op	    1660 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinBinSig-NonVecBuiltinFunc-8      	   10000	    174385 ns/op	   59789 B/op	    1660 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 26, 2019
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 27, 2019
@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #12427 into master will decrease coverage by 0.0043%.
The diff coverage is 75%.

@@               Coverage Diff                @@
##             master     #12427        +/-   ##
================================================
- Coverage   79.7607%   79.7564%   -0.0044%     
================================================
  Files           462        462                
  Lines        102000     101983        -17     
================================================
- Hits          81356      81338        -18     
  Misses        14776      14776                
- Partials       5868       5869         +1

@sre-bot
Copy link
Contributor

sre-bot commented Sep 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit 6242b25 into pingcap:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants