Skip to content

types/data: the bit data type should be treat as uint64 (#11951)#12423

Merged
zz-jason merged 5 commits intopingcap:release-3.0from
sre-bot:release-3.0-2bba5654b456
Sep 27, 2019
Merged

types/data: the bit data type should be treat as uint64 (#11951)#12423
zz-jason merged 5 commits intopingcap:release-3.0from
sre-bot:release-3.0-2bba5654b456

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 26, 2019

cherry-pick #11951 to release-3.0


What problem does this PR solve?

Fix #11895
the -1 can't be insert into a bit column.

What is changed and how it works?

  1. when convert to mysql bit, mapped it to unsigned int.
  2. the error is wrong (it should be data too long instead of out of range)

Check List

Tests

  • Unit test -- added test cases

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 26, 2019

/run-all-tests

@sre-bot sre-bot added contribution This PR is from a community contributor. type/3.0 cherry-pick type/bugfix This PR fixes a bug. labels Sep 26, 2019
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit b736230 into pingcap:release-3.0 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants