expression: implement vectorized evaluation for builtinAbsUIntSig#12400
Merged
sre-bot merged 6 commits intopingcap:masterfrom Sep 27, 2019
Merged
expression: implement vectorized evaluation for builtinAbsUIntSig#12400sre-bot merged 6 commits intopingcap:masterfrom
builtinAbsUIntSig#12400sre-bot merged 6 commits intopingcap:masterfrom
Conversation
builtinAbsUIntSig
zz-jason
reviewed
Sep 26, 2019
qw4990
reviewed
Sep 26, 2019
Contributor
qw4990
left a comment
There was a problem hiding this comment.
Almost LGTM, but please reorg the import packages.
Codecov Report
@@ Coverage Diff @@
## master #12400 +/- ##
===========================================
Coverage 79.8172% 79.8172%
===========================================
Files 462 462
Lines 102340 102340
===========================================
Hits 81685 81685
Misses 14787 14787
Partials 5868 5868 |
0b4b11e to
a04082d
Compare
qw4990
approved these changes
Sep 27, 2019
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for builtinAbsUIntSig.
Issue: #12103
What is changed and how it works?
Check List
Tests