build: make errcheck works correctly#12381
Merged
sre-bot merged 5 commits intopingcap:masterfrom Sep 26, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12381 +/- ##
===========================================
Coverage 79.8814% 79.8814%
===========================================
Files 462 462
Lines 102423 102423
===========================================
Hits 81817 81817
Misses 14738 14738
Partials 5868 5868 |
SunRunAway
reviewed
Sep 26, 2019
Contributor
|
LGTM |
Deardrops
reviewed
Sep 26, 2019
Contributor
|
Your auto merge job has been accepted, waiting for 11951, 12252 |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the broken errcheck after #11807.
What is changed and how it works?
golang.org/x/toolsused by errcheck-ignoretestsCheck List
Tests