expression: implement vectorized evaluation for builtinLogicOrSig#12365
expression: implement vectorized evaluation for builtinLogicOrSig#12365ngaut merged 7 commits intopingcap:masterfrom
Conversation
|
Thanks! @k-ye Would you like to join our channel #wg-vec-expr in the tidbcommunity slacks workspace for more discussion? |
@Reminiscent Sounds great! I've joined now 😃 |
|
@k-ye Almost LGTM, but please solve the conflict. |
|
Since the logical AND operator has been committed, I think the customized data generator could be applied to it as well, and thus added f6fb834. Please let me know if you think this is necessary, or we should do it in a separate PR, thx! |
Codecov Report
@@ Coverage Diff @@
## master #12365 +/- ##
===========================================
Coverage 79.7499% 79.7499%
===========================================
Files 462 462
Lines 101960 101960
===========================================
Hits 81313 81313
Misses 14789 14789
Partials 5858 5858 |
|
Your auto merge job has been accepted, waiting for 12399 |
|
/run-all-tests |
|
@k-ye merge failed. |
|
/run-all-tests |
|
/run-unit-test |
| } else { | ||
| i64s[i] = 0 | ||
| } | ||
| result.SetNull(i, isNull) |
There was a problem hiding this comment.
How about do an extra optimization here,
if isNull0 != isNull {
result.SetNull(i, isNull)
}
What problem does this PR solve?
Implement vectorized evaluation for builtinLogicOrSig for #12103.
What is changed and how it works?
According to benchmark, about 4 times faster than before:
Check List
Tests