Skip to content

planner: use another way to restore table name in hint#12358

Merged
sre-bot merged 7 commits intopingcap:masterfrom
winoros:offset-fix
Sep 27, 2019
Merged

planner: use another way to restore table name in hint#12358
sre-bot merged 7 commits intopingcap:masterfrom
winoros:offset-fix

Conversation

@winoros
Copy link
Member

@winoros winoros commented Sep 24, 2019

What problem does this PR solve?

Use another way to not rely on the *Names of expression.Column.

Check List

Tests

  • Unit test

Release note

  • Write release note for bug-fix or new feature.

@winoros winoros requested review from alivxxx and foreyes September 24, 2019 11:52
@winoros winoros added the sig/planner SIG: Planner label Sep 24, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #12358 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12358   +/-   ##
===========================================
  Coverage   80.0332%   80.0332%           
===========================================
  Files           462        462           
  Lines        103392     103392           
===========================================
  Hits          82748      82748           
  Misses        14750      14750           
  Partials       5894       5894

@winoros
Copy link
Member Author

winoros commented Sep 26, 2019

/run-unit-test

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winoros winoros requested a review from foreyes September 27, 2019 09:23
Copy link
Contributor

@foreyes foreyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foreyes foreyes added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit 0f4a545 into pingcap:master Sep 27, 2019
@winoros winoros deleted the offset-fix branch November 11, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants