Skip to content

expression: implement vectorized evaluation for builtinLog2ArgsSig#12279

Merged
ngaut merged 18 commits intopingcap:masterfrom
tsthght:builtinLog2ArgsSig
Sep 26, 2019
Merged

expression: implement vectorized evaluation for builtinLog2ArgsSig#12279
ngaut merged 18 commits intopingcap:masterfrom
tsthght:builtinLog2ArgsSig

Conversation

@tsthght
Copy link
Contributor

@tsthght tsthght commented Sep 19, 2019

What problem does this PR solve?

expression: implement vectorized evaluation for builtinLog2ArgsSig,for #12105

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinMathFunc/builtinLog2ArgsSig-VecBuiltinFunc-8         	  100000	     15137 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinLog2ArgsSig-NonVecBuiltinFunc-8      	   50000	     35137 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 19, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #12279 into master will decrease coverage by 0.0361%.
The diff coverage is 72.7272%.

@@               Coverage Diff               @@
##            master     #12279        +/-   ##
===============================================
- Coverage   79.779%   79.7428%   -0.0362%     
===============================================
  Files          462        462                
  Lines       102537     101796       -741     
===============================================
- Hits         81803      81175       -628     
+ Misses       14865      14766        -99     
+ Partials      5869       5855        -14

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reminiscent
Reminiscent previously approved these changes Sep 23, 2019
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent
Copy link
Contributor

@tsthght Please resolve the conflict, Thanks.

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 23, 2019
@qw4990
Copy link
Contributor

qw4990 commented Sep 25, 2019

/run-unit-test

@qw4990
Copy link
Contributor

qw4990 commented Sep 25, 2019

@tsthght Please resolve the CI problem.

@qw4990
Copy link
Contributor

qw4990 commented Sep 25, 2019

@tsthght Please solve the CI problem.

@ngaut ngaut merged commit 69ccc6e into pingcap:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants