Skip to content

expression: implement vectorized evaluation for builtinFloorRealSig#12277

Merged
sre-bot merged 25 commits intopingcap:masterfrom
tsthght:builtinFloorRealSig
Sep 28, 2019
Merged

expression: implement vectorized evaluation for builtinFloorRealSig#12277
sre-bot merged 25 commits intopingcap:masterfrom
tsthght:builtinFloorRealSig

Conversation

@tsthght
Copy link
Contributor

@tsthght tsthght commented Sep 19, 2019

What problem does this PR solve?

expression: implement vectorized evaluation for builtinFloorRealSig, for #12105

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinMathFunc/builtinFloorRealSig-VecBuiltinFunc-8         	 1000000	      2168 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinFloorRealSig-NonVecBuiltinFunc-8      	  100000	     21896 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 19, 2019
@qw4990
Copy link
Contributor

qw4990 commented Sep 22, 2019

/run-check_dev_2

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #12277 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12277   +/-   ##
===========================================
  Coverage   79.7662%   79.7662%           
===========================================
  Files           462        462           
  Lines        102235     102235           
===========================================
  Hits          81549      81549           
  Misses        14804      14804           
  Partials       5882       5882

@qw4990
Copy link
Contributor

qw4990 commented Sep 26, 2019

/run-all-test

@qw4990
Copy link
Contributor

qw4990 commented Sep 26, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Sep 26, 2019

@zz-jason PTAL~

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2019

Your auto merge job has been accepted, waiting for 12432

@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2019

/run-all-tests

@sre-bot sre-bot merged commit d4bab3d into pingcap:master Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants