Skip to content

expression: implement vectorized evaluation for builtinPowSig#12242

Merged
sre-bot merged 11 commits intopingcap:masterfrom
tsthght:builtinPowSig
Sep 18, 2019
Merged

expression: implement vectorized evaluation for builtinPowSig#12242
sre-bot merged 11 commits intopingcap:masterfrom
tsthght:builtinPowSig

Conversation

@tsthght
Copy link
Contributor

@tsthght tsthght commented Sep 18, 2019

What problem does this PR solve?

implement vectorized evaluation for builtinPowSig, for #12105

What is changed and how it works?

BenchmarkVectorizedBuiltinMathFunc/builtinPowSig-VecBuiltinFunc-8               	   50000	     30863 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinPowSig-NonVecBuiltinFunc-8            	   30000	     49697 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 18, 2019
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2019

CLA assistant check
All committers have signed the CLA.

@zz-jason
Copy link
Member

@tsthght Could you update the benchmark result in the PR description?

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #12242 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12242   +/-   ##
===========================================
  Coverage   81.1266%   81.1266%           
===========================================
  Files           454        454           
  Lines         98811      98811           
===========================================
  Hits          80162      80162           
  Misses        12881      12881           
  Partials       5768       5768

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990
Copy link
Contributor

qw4990 commented Sep 18, 2019

/run-unit-test

Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

Your auto merge job has been accepted, waiting for 12253

@Reminiscent Reminiscent removed the request for review from zz-jason September 18, 2019 12:49
@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit a1a308b into pingcap:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants