Skip to content

expression: implement vectorized evaluation for builtinRoundDecSig#12216

Merged
sre-bot merged 2 commits intopingcap:masterfrom
FateTHarlaown:round
Sep 17, 2019
Merged

expression: implement vectorized evaluation for builtinRoundDecSig#12216
sre-bot merged 2 commits intopingcap:masterfrom
FateTHarlaown:round

Conversation

@FateTHarlaown
Copy link
Contributor

What problem does this PR solve?

implement vectorized evaluation for builtinRoundDecSig, for #12102

What is changed and how it works?

over 2 times faster than before.

BenchmarkVectorizedBuiltinMathFunc/builtinRoundDecSig-VecBuiltinFunc-8      	  100000	     23671 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinRoundDecSig-NonVecBuiltinFunc-8   	   30000	     50865 ns/op	   39552 B/op	     824 allocs/op

Check List

Tests
Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 17, 2019
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #12216 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12216   +/-   ##
===========================================
  Coverage   81.1538%   81.1538%           
===========================================
  Files           454        454           
  Lines         98450      98450           
===========================================
  Hits          79896      79896           
  Misses        12815      12815           
  Partials       5739       5739

Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 17, 2019

/run-all-tests

@sre-bot sre-bot merged commit 5f6b22c into pingcap:master Sep 17, 2019
@FateTHarlaown FateTHarlaown deleted the round branch September 18, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants