expression: implement vectorized evaluation for builtinCastIntAsRealSig#12214
Merged
sre-bot merged 12 commits intopingcap:masterfrom Sep 17, 2019
Merged
expression: implement vectorized evaluation for builtinCastIntAsRealSig#12214sre-bot merged 12 commits intopingcap:masterfrom
sre-bot merged 12 commits intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12214 +/- ##
=========================================
Coverage 81.169% 81.169%
=========================================
Files 454 454
Lines 98938 98938
=========================================
Hits 80307 80307
Misses 12856 12856
Partials 5775 5775 |
Reminiscent
reviewed
Sep 17, 2019
qw4990
reviewed
Sep 17, 2019
Member
|
/rebuild |
qw4990
reviewed
Sep 17, 2019
Contributor
qw4990
left a comment
There was a problem hiding this comment.
Please resolve these conflicts.
Contributor
|
Your auto merge job has been accepted, waiting for 12221, 12222 |
Contributor
|
/run-all-tests |
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for builtinCastIntAsRealSig, for #12105
What is changed and how it works?
according to benchmark, about 5 times faster than before:
and if we use mergeNulls(),the performance become even better
Check List
Tests