testutil: remove unnecessary flag parse#12197
Merged
alivxxx merged 5 commits intopingcap:masterfrom Sep 17, 2019
Merged
Conversation
Contributor
Author
|
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #12197 +/- ##
===========================================
Coverage 81.2659% 81.2659%
===========================================
Files 457 457
Lines 100245 100245
===========================================
Hits 81465 81465
Misses 12988 12988
Partials 5792 5792 |
Contributor
|
Your auto merge job has been accepted, waiting for 12133 |
Contributor
|
/run-all-tests |
Contributor
|
@lamxTyler merge failed. |
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
/run-all-tests |
ngaut
approved these changes
Sep 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Unit test under go 1.13 will fail with
flag provided but not defined: -test.testlogfile.What is changed and how it works?
Remove
flag.Parsein testutil since other flags may not have been defined.Check List
Tests
run
make testusing go 1.13 sucessfully.Code changes
Side effects
Related changes
Release note