implement vectorized evaluation for builtinSqrtSig#12187
Merged
qw4990 merged 1 commit intopingcap:masterfrom Sep 16, 2019
jacklightChen:sqrt
Merged
implement vectorized evaluation for builtinSqrtSig#12187qw4990 merged 1 commit intopingcap:masterfrom jacklightChen:sqrt
qw4990 merged 1 commit intopingcap:masterfrom
jacklightChen:sqrt
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #12187 +/- ##
===============================================
- Coverage 81.579% 81.1832% -0.3959%
===============================================
Files 454 454
Lines 99425 97987 -1438
===============================================
- Hits 81110 79549 -1561
- Misses 12607 12712 +105
- Partials 5708 5726 +18 |
Contributor
|
Thanks! @jacklightChen Please update your branch to the latest version and try it again. |
Contributor
|
/run-all-tests |
Contributor
|
@jacklightChen merge failed. |
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for builtinSqrtSig, for #12105
What is changed and how it works?
according to benchmark, about 5 times faster than before:
ps:if we don't check
result.IsNull(i)in the loop,the method is only 3 times faster than before, so it's better to add those check nulls codes:Check List
Tests