planner: support basic Show in cascades planner#12185
Merged
sre-bot merged 11 commits intopingcap:masterfrom Sep 17, 2019
Merged
planner: support basic Show in cascades planner#12185sre-bot merged 11 commits intopingcap:masterfrom
sre-bot merged 11 commits intopingcap:masterfrom
Conversation
Signed-off-by: Zhang Jian <zjsariel@gmail.com>
francis0407
reviewed
Sep 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #12185 +/- ##
================================================
- Coverage 81.1538% 81.1254% -0.0285%
================================================
Files 454 454
Lines 98450 98450
================================================
- Hits 79896 79868 -28
- Misses 12815 12831 +16
- Partials 5739 5751 +12 |
…ason/tidb into cascades/support-basic-show
Member
Author
Added. PTAL again, thx. |
…ason/tidb into cascades/support-basic-show
winoros
approved these changes
Sep 17, 2019
| logicProp := expr.Group.Prop | ||
| show := expr.ExprNode.(*plannercore.LogicalShow) | ||
|
|
||
| // TODO(zz-jason): unifying LogicalShow and PhysicalShow to a single |
Member
There was a problem hiding this comment.
Here also comes up with a question, for operators that only has one physical operator. Do we need to split it to logical one and physical one?
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhang Jian zjsariel@gmail.com
What problem does this PR solve?
LogicalShowin the cascades plannerWhat is changed and how it works?
LogicalShow.LogicalShowtoPhysicalShow.Check List
Tests
Code changes