expression: implement vectorized evaluation for builtinInetNtoaSig#12088
Merged
sre-bot merged 15 commits intopingcap:masterfrom Sep 10, 2019
Merged
expression: implement vectorized evaluation for builtinInetNtoaSig#12088sre-bot merged 15 commits intopingcap:masterfrom
builtinInetNtoaSig#12088sre-bot merged 15 commits intopingcap:masterfrom
Conversation
qw4990
reviewed
Sep 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #12088 +/- ##
================================================
- Coverage 81.3875% 81.3354% -0.0522%
================================================
Files 452 451 -1
Lines 96618 96584 -34
================================================
- Hits 78635 78557 -78
- Misses 12363 12397 +34
- Partials 5620 5630 +10 |
SunRunAway
reviewed
Sep 9, 2019
| result.AppendNull() | ||
| continue | ||
| } | ||
| ip := make(net.IP, net.IPv4len) |
Contributor
There was a problem hiding this comment.
Could we reuse this buffer during for loop?
Contributor
There was a problem hiding this comment.
Any benchmark result update?
Contributor
Author
There was a problem hiding this comment.
Update. But it seems that the promotion is not obvious.
Contributor
There was a problem hiding this comment.
We can use option benchmem to see the benchmark of memory.
go test -benchmem
…InetNtoaSig # Conflicts: # expression/bench_test.go
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for builtinInetNtoaSig.
What is changed and how it works?
Check List
Tests