expression: implement vectorized evaluation for builtinLowerStr#12013
Merged
sre-bot merged 11 commits intopingcap:masterfrom Sep 11, 2019
Merged
expression: implement vectorized evaluation for builtinLowerStr#12013sre-bot merged 11 commits intopingcap:masterfrom
builtinLowerStr#12013sre-bot merged 11 commits intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12013 +/- ##
==============================================
+ Coverage 81.2734% 81.33% +0.0565%
==============================================
Files 452 450 -2
Lines 96697 96583 -114
==============================================
- Hits 78589 78551 -38
+ Misses 12466 12398 -68
+ Partials 5642 5634 -8 |
Contributor
Author
|
/run-all-tests |
ngaut
reviewed
Sep 3, 2019
Contributor
Author
|
/run-unit-test |
XuHuaiyu
reviewed
Sep 4, 2019
zz-jason
reviewed
Sep 4, 2019
Member
|
to #12058 |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for
builtinLowerStr.What is changed and how it works?
Almost 2x faster than before:
Check List
Tests