Skip to content

there are some memory leak in TTL's implement #45510

New issue
New issue
Closed
#45512
Closed
there are some memory leak in TTL's implement#45510
#45512
Labels
affects-6.6affects-7.0affects-7.1This bug affects the 7.1.x(LTS) versions.affects-7.2severity/majorsig/sql-infraSIG: SQL Infratype/bugThe issue is confirmed as a bug.
@lcwangchao

Description

@lcwangchao
lcwangchao
opened on Jul 24, 2023

If you run tidb with a very long time with many TTL tables, you can seem some memory leak:

image

  1. dettachStatsCollector , see:

tidb/session/session.go

Lines 3660 to 3665 in 9e20208

func detachStatsCollector(s *session) *session {
s.statsCollector = nil
s.idxUsageCollector = nil
return s
}

it only sets two collectors to nil but did not call Delete for it.

  1. The context created here is not guaranteed to be cancelled finally:

tidb/ttl/ttlworker/task_manager.go

Lines 391 to 399 in 9e20208

ctx, cancel := context.WithCancel(m.ctx)
scanTask := &ttlScanTask{
ctx: ctx,
TTLTask: task,
tbl: table,
statistics: &ttlStatistics{},
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    affects-6.6affects-7.0affects-7.1This bug affects the 7.1.x(LTS) versions.affects-7.2severity/majorsig/sql-infraSIG: SQL Infratype/bugThe issue is confirmed as a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions