Skip to content

data race in the stmtsummary #41275

@hawkingrei

Description

@hawkingrei

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

==================
WARNING: DATA RACE
Read at 0x0000027e63a0 by goroutine 69:
  github.com/pingcap/tidb/util/stmtsummary/v2.(*StmtSummary).rotateLoop()
      util/stmtsummary/v2/stmtsummary.go:368 +0x185
  github.com/pingcap/tidb/util/stmtsummary/v2.NewStmtSummary4Test.func1()
      util/stmtsummary/v2/stmtsummary.go:148 +0x72
Previous write at 0x0000027e63a0 by goroutine 68:
  github.com/pingcap/tidb/util/stmtsummary/v2.TestStmtSummary()
      util/stmtsummary/v2/stmtsummary_test.go:62 +0x4a8
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47
Goroutine 69 (running) created at:
  github.com/pingcap/tidb/util/stmtsummary/v2.NewStmtSummary4Test()
      util/stmtsummary/v2/stmtsummary.go:146 +0x4ce
  github.com/pingcap/tidb/util/stmtsummary/v2.TestStmtSummary()
      util/stmtsummary/v2/stmtsummary_test.go:47 +0x47
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47
Goroutine 68 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1493 +0x75d
  testing.runTests.func1()
      GOROOT/src/testing/testing.go:1846 +0x99
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.runTests()
      GOROOT/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      GOROOT/src/testing/testing.go:1726 +0xa84
  go.uber.org/goleak.VerifyTestMain()
      external/org_uber_go_goleak/testmain.go:53 +0x70
  github.com/pingcap/tidb/util/stmtsummary/v2.TestMain()
      util/stmtsummary/v2/main_test.go:32 +0x43c
  main.main()
      bazel-out/k8-fastbuild/bin/util/stmtsummary/v2/stmtsummary_test_/testmain.go:120 +0x5e8
================== 

4. What is your TiDB version? (Required)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions