data race when test in br/pkg/lightning/log #30185
Description
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
make race
2. What did you expect to see? (Required)
nothing error
3. What did you see instead (Required)
WARNING: DATA RACE
Write at 0x0000089ee198 by goroutine 51:
github.com/pingcap/tidb/br/pkg/lightning/log.InitLogger()
/go/tidb/br/pkg/lightning/log/log.go:113 +0x364
github.com/pingcap/tidb/br/pkg/lightning/restore.(*chunkRestoreSuite).TestEncodeLoopIgnoreColumnsCSV()
/go/tidb/br/pkg/lightning/restore/restore_test.go:1492 +0x91
runtime.call16()
/usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
reflect.Value.Call()
/usr/local/go/src/reflect/value.go:337 +0xd8
github.com/pingcap/check.(*suiteRunner).forkTest.func1()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
github.com/pingcap/check.(*suiteRunner).forkCall.func1()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
Previous read at 0x0000089ee198 by goroutine 104:
github.com/pingcap/tidb/br/pkg/lightning/restore.(*Controller).buildRunPeriodicActionAndCancelFunc.func6()
/go/tidb/br/pkg/lightning/restore/restore.go:1145 +0x52b
Goroutine 51 (running) created at:
github.com/pingcap/check.(*suiteRunner).forkCall()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:734 +0x4cc
github.com/pingcap/check.(*suiteRunner).forkTest()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:832 +0x1c4
github.com/pingcap/check.(*suiteRunner).doRun()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:666 +0x144
github.com/pingcap/check.(*suiteRunner).run()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:696 +0x144
github.com/pingcap/check.Run()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/run.go:150 +0x5a
github.com/pingcap/check.RunAll()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/run.go:113 +0xff6
github.com/pingcap/check.TestingT()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/run.go:99 +0x756
github.com/pingcap/tidb/br/pkg/lightning/restore.TestTiDB()
/go/tidb/br/pkg/lightning/restore/tidb_test.go:45 +0x38
testing.tRunner()
/usr/local/go/src/testing/testing.go:1193 +0x202
Goroutine 104 (finished) created at:
github.com/pingcap/tidb/br/pkg/lightning/restore.(*Controller).restoreTables()
/go/tidb/br/pkg/lightning/restore/restore.go:1441 +0x427
github.com/pingcap/tidb/br/pkg/lightning/restore.(*tableRestoreSuite).TestTableRestoreMetrics()
/go/tidb/br/pkg/lightning/restore/restore_test.go:1088 +0x187d
runtime.call16()
/usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
reflect.Value.Call()
/usr/local/go/src/reflect/value.go:337 +0xd8
github.com/pingcap/check.(*suiteRunner).forkTest.func1()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
github.com/pingcap/check.(*suiteRunner).forkCall.func1()
/home/prow/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d