version: unify Git Commit Hash and Branch info for legacy and new architectures#827
Merged
wlwilliamx merged 1 commit intopingcap:masterfrom Jan 9, 2025
Conversation
…hitectures This commit updates the `cdc version` command to always display the Git Commit Hash and Branch from the new architecture repository. This ensures consistency in version reporting, as TiCDC binaries are now built exclusively from the new architecture repository. Users can still find the legacy architecture's commit details in the `go.mod` file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #826
What is changed and how it works?
This PR updates the cdc version command to always display the Git Commit Hash and Branch from the new architecture repository. Since TiCDC binaries are built exclusively from the new architecture, this change ensures consistency in version reporting.
Users can still find the legacy architecture’s Git Commit Hash and build details in the go.mod file, e.g.:
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note