*: implement basic flow control#733
Merged
asddongmen merged 14 commits intopingcap:masterfrom Dec 31, 2024
Merged
Conversation
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com> DS: fix panic Signed-off-by: dongmen <414110582@qq.com> DS: fix bug Signed-off-by: dongmen <414110582@qq.com> eventcollector: adjust some codes Signed-off-by: dongmen <414110582@qq.com> eventcollector: fix sentResolvedTs being update unexpectedly Signed-off-by: dongmen <414110582@qq.com> eventbroker: update some comments Signed-off-by: dongmen <414110582@qq.com> eventbroker: fix unit test Signed-off-by: dongmen <414110582@qq.com> small changes Signed-off-by: dongmen <414110582@qq.com> workload: fix workload Signed-off-by: dongmen <414110582@qq.com> code adjust Signed-off-by: dongmen <414110582@qq.com> *: implement a simpler flow control Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
hongyunyan
reviewed
Dec 30, 2024
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
| // Caller should avoid to use this method if the remote EventService maybe offline forever. | ||
| // Caller should avoid to use this method when the remote EventService is offline forever. | ||
| // And this method may be deprecated in the future. | ||
| // FIXME: Add a checking mechanism to avoid sending request to offline EventService. |
Collaborator
There was a problem hiding this comment.
Shall we also create a issue for this? to prevent too much FIXME and TODO in the code base ?
Comment on lines
669
to
675
| d.eventServiceInfo.RLock() | ||
| defer d.eventServiceInfo.RUnlock() | ||
|
|
||
| if d.eventServiceInfo.serverID == "" || !d.eventServiceInfo.readyEventReceived { | ||
| log.Panic("should not happen: reset dispatcher before receiving ready signal") | ||
| // Just ignore the request if the dispatcher is not ready. | ||
| return | ||
| } |
Collaborator
There was a problem hiding this comment.
It looks this can be split to a method
Collaborator
Author
There was a problem hiding this comment.
Good advice, I will do it in a separate PR.
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
hongyunyan
approved these changes
Dec 31, 2024
3AceShowHand
approved these changes
Dec 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #736
What is changes?
This PR introduces path-level and area-level flow control mechanisms.
For detailed explanations of these concepts, please refer to the documentation added in this PR.
Testing
Manual Testing: Verified the functionality through manual testing.
As shown in the diagram below, a path is paused when its used memory exceeds 20% of the maximum quota.