test: recover fail_over_ddl_mix_with_syncpoint intergration test#1531
test: recover fail_over_ddl_mix_with_syncpoint intergration test#1531ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
fail_over_ddl_mix_with_syncpoint intergration test#1531Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @hongyunyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on the fail_over_ddl_mix_with_syncpoint integration test. To facilitate its recovery or debugging, the CI configuration script run_heavy_it_in_ci.sh has been updated to run only this particular test across all available MySQL test groups, effectively isolating its execution for focused analysis.
Highlights
- CI Test Configuration: The
run_heavy_it_in_ci.shscript has been modified to exclusively execute thefail_over_ddl_mix_with_syncpointintegration test across all definedmysql_groups. This change appears to be a temporary measure to isolate and focus on the recovery or debugging of this specific test, as indicated by the PR title.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request modifies the run_heavy_it_in_ci.sh script to recover the fail_over_ddl_mix_with_syncpoint integration test. However, the change overwrites all mysql test groups with the same test case, which is likely unintended and reduces test coverage. This needs to be addressed to ensure all tests are executed as expected.
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G01 | ||
| 'api_v2 ddl_for_split_tables_with_random_move_table' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G02 | ||
| 'availability ddl_for_split_tables_with_failover' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G03 | ||
| '' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G04 | ||
| 'syncpoint syncpoint_check_ts' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G05 | ||
| 'move_table ddl_for_split_tables_with_merge_and_split' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G06 | ||
| 'cdc ddl_for_split_tables_with_random_merge_and_split' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G07 | ||
| 'resolve_lock merge_table' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G08 | ||
| 'bank' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G09 | ||
| 'drop_many_tables' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G10 | ||
| 'default_value http_proxies' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G11 | ||
| 'ddl_reentrant force_replicate_table' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G12 | ||
| 'tidb_mysql_test ddl_with_random_move_table' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G13 | ||
| 'fail_over region_merge' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G14 | ||
| 'fail_over_ddl_mix' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G15 | ||
| #'fail_over_ddl_mix_with_syncpoint' | ||
| 'fail_over_ddl_mix_with_syncpoint' |
There was a problem hiding this comment.
The mysql_groups array is being overwritten with the same test case 'fail_over_ddl_mix_with_syncpoint' for all groups. This defeats the purpose of having multiple groups, as only this test case will be executed. Consider restoring the original test cases for each group to ensure comprehensive testing. If the intention is to only run this test, consider removing the other entries to avoid confusion.
This could lead to other tests not being run, which is a high severity issue.
mysql_groups=(
# G00
'generate_column many_pk_or_uk multi_source'
# G01
'api_v2 ddl_for_split_tables_with_random_move_table'
# G02
'availability ddl_for_split_tables_with_failover'
# G03
''
# G04
'syncpoint syncpoint_check_ts'
# G05
'move_table ddl_for_split_tables_with_merge_and_split'
# G06
'cdc ddl_for_split_tables_with_random_merge_and_split'
# G07
'resolve_lock merge_table'
# G08
'bank'
# G09
'drop_many_tables'
# G10
'default_value http_proxies'
# G11
'ddl_reentrant force_replicate_table'
# G12
'tidb_mysql_test ddl_with_random_move_table'
# G13
'fail_over region_merge'
# G14
'fail_over_ddl_mix'
# G15
#'fail_over_ddl_mix_with_syncpoint'
)|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@hongyunyan: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #1477
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note