Add hint for broadcast join. (#818)#950
Merged
hanfei1991 merged 1 commit intopingcap:release-4.0from Jul 29, 2020
Merged
Conversation
* add hint for bc join * refine * add hint for bc join * refine * refine * refine * refine again * pass test * fix compile error * add prefer local * use bcj_local * change bc_join to broadcast_join Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: ichn-hu <zfhu16@fudan.edu.cn>
Codecov Report
@@ Coverage Diff @@
## release-4.0 #950 +/- ##
===============================================
+ Coverage 78.25% 78.38% +0.13%
===============================================
Files 40 40
Lines 14710 14802 +92
===============================================
+ Hits 11511 11603 +92
+ Misses 2519 2515 -4
- Partials 680 684 +4 |
Member
Author
|
/run-all-tests |
Contributor
|
@lzmhhh123,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: ddl(slack). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add hint for bc join
refine
add hint for bc join
refine
refine
refine
refine again
pass test
fix compile error
add prefer local
use bcj_local
change bc_join to broadcast_join
Co-authored-by: xufei xufeixw@mail.ustc.edu.cn
Co-authored-by: ichn-hu zfhu16@fudan.edu.cn
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes