Skip to content

revert fine_grained_shuffle related field#953

Merged
gengliqi merged 1 commit intopingcap:masterfrom
guo-shaoge:revert_fine_grained_shuffle
Jul 5, 2022
Merged

revert fine_grained_shuffle related field#953
gengliqi merged 1 commit intopingcap:masterfrom
guo-shaoge:revert_fine_grained_shuffle

Conversation

@guo-shaoge
Copy link
Contributor

Signed-off-by: guo-shaoge shaoge1994@163.com
Revert #924
Add in tipb instead: pingcap/tipb#266

Copy link
Contributor

@gengliqi gengliqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the revert is not complete? PR #924 added 323 lines of code and removed 130 lines of code.

@guo-shaoge guo-shaoge force-pushed the revert_fine_grained_shuffle branch from 673385b to a898d27 Compare July 5, 2022 05:28
@guo-shaoge
Copy link
Contributor Author

Looks like this pr(#911) didn't generate pb file. It's generated in #924 . But this pr only need to change pkg/mpp/mpp.pb.go.

@gengliqi gengliqi merged commit aa9c2d2 into pingcap:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants