Add a new key error type AssertionFailed#815
Merged
disksing merged 3 commits intopingcap:masterfrom Oct 11, 2021
Merged
Conversation
cf0f94e to
e706d94
Compare
This was referenced Sep 23, 2021
Merged
8 tasks
disksing
approved these changes
Oct 9, 2021
Contributor
Contributor
|
LGTM while I think we can keep it until the related PR is ready to merge, in case there are still some small changes. |
ekexium
approved these changes
Oct 9, 2021
proto/kvrpcpb.proto
Outdated
Comment on lines
+766
to
+767
| uint64 existed_start_ts = 4; | ||
| uint64 existed_commit_ts = 5; |
Member
There was a problem hiding this comment.
Suggested change
| uint64 existed_start_ts = 4; | |
| uint64 existed_commit_ts = 5; | |
| uint64 existing_start_ts = 4; | |
| uint64 existing_commit_ts = 5; |
proto/kvrpcpb.proto
Outdated
| CommitTsExpired commit_ts_expired = 7; // Commit ts is earlier than min commit ts of a transaction. | ||
| TxnNotFound txn_not_found = 8; // Txn not found when checking txn status. | ||
| CommitTsTooLarge commit_ts_too_large = 9; // Calculated commit TS exceeds the limit given by the user. | ||
| AssertionFailed assertion_failed = 10; // Assertion of a `Mutation` is evaluated to fail. |
Member
There was a problem hiding this comment.
Suggested change
| AssertionFailed assertion_failed = 10; // Assertion of a `Mutation` is evaluated to fail. | |
| AssertionFailed assertion_failed = 10; // Assertion of a `Mutation` is evaluated as a failure. |
Contributor
|
@MyonKeminta want to address comments? |
Contributor
Author
Sorry I wasn't working on this for some time. I'll do it now |
Closed
Contributor
Author
|
🤔 Actually this PR don't need to be merged so early... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be part of pingcap/tidb#26833