Skip to content

Support replacing lock by key for deadlock detector service#1259

Merged
cfzjywxk merged 5 commits intopingcap:masterfrom
MyonKeminta:m/deadlock-replace-lock-by-key
Sep 3, 2024
Merged

Support replacing lock by key for deadlock detector service#1259
cfzjywxk merged 5 commits intopingcap:masterfrom
MyonKeminta:m/deadlock-replace-lock-by-key

Conversation

@MyonKeminta
Copy link
Contributor

This is part of fixing the issue tikv/tikv#17394

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the tikv/tikv#17451

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Sep 3, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-03 03:10:18.774248784 +0000 UTC m=+327543.292301710: ☑️ agreed by cfzjywxk.
  • 2024-09-03 10:07:30.891447981 +0000 UTC m=+352575.409500913: ☑️ agreed by ekexium.
  • 2024-09-03 10:57:48.459479203 +0000 UTC m=+355592.977532130: ✖️🔁 reset by MyonKeminta.
  • 2024-09-03 11:05:34.994249409 +0000 UTC m=+356059.512302334: ☑️ agreed by ekexium.
  • 2024-09-03 11:36:12.205736602 +0000 UTC m=+357896.723789521: ☑️ agreed by cfzjywxk.

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Sep 3, 2024

/merge

@cfzjywxk cfzjywxk merged commit 767001c into pingcap:master Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants