Add start_ts to PrepareFlashbackToVersionRequest#1016
Merged
Defined2014 merged 2 commits intopingcap:masterfrom Nov 29, 2022
Merged
Add start_ts to PrepareFlashbackToVersionRequest#1016Defined2014 merged 2 commits intopingcap:masterfrom
Defined2014 merged 2 commits intopingcap:masterfrom
Conversation
Defined2014
approved these changes
Nov 18, 2022
HuSharp
approved these changes
Nov 18, 2022
f4a7aac to
3ddebcc
Compare
3ddebcc to
2d999b1
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
3e35904 to
ca335ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato ghzpotato@gmail.com
Since v6.4 is a DMR version, we skipped the compatibility consideration here and removed
start_tsfromFlashbackToVersionRequest. Also, updating the cluster during the flashback is also an infrequent behavior, I think we don't need to care about it too much.