Skip to content

tpcc: refresh conn if pingContext fails#76

Merged
mahjonp merged 2 commits intomasterfrom
tpcc_refresh_conn
Mar 29, 2021
Merged

tpcc: refresh conn if pingContext fails#76
mahjonp merged 2 commits intomasterfrom
tpcc_refresh_conn

Conversation

@mahjonp
Copy link
Copy Markdown
Collaborator

@mahjonp mahjonp commented Mar 27, 2021 •
edited
Loading

Signed-off-by: mahjonp junpeng.man@gmail.com

This PR fixes the invalid connection error when the tidb-server is killed

[mysql] 2021/03/27 07:50:25 packets.go:36: unexpected EOF
[2021-03-27 07:50:25] execute run failed, err invalid connection
[2021-03-27 07:50:25] execute run failed, err invalid connection
[2021-03-27 07:50:25] execute run failed, err invalid connection
execute run failed, err invalid connection
execute run failed, err invalid connection
execute run failed, err invalid connection
[2021-03-27 07:50:25] execute run failed, err invalid connection
execute run failed, err invalid connection
[mysql] 2021/03/27 07:50:25 packets.go:36: unexpected EOF
[mysql] 2021/03/27 07:50:25 packets.go:36: unexpected EOF

@mahjonp
refresh conn if ping fails
09883d2 
Signed-off-by: mahjonp <junpeng.man@gmail.com>
@mahjonp mahjonp requested a review from cosven March 27, 2021 12:01
cosven
cosven approved these changes Mar 28, 2021
View reviewed changes
Copy link
Copy Markdown

@cosven cosven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Comment thread pkg/workload/base.go Outdated
@mahjonp
fix a typo
4631cc3 
Signed-off-by: mahjonp <junpeng.man@gmail.com>
@mahjonp mahjonp merged commit 9173047 into master Mar 29, 2021
@mahjonp mahjonp deleted the tpcc_refresh_conn branch March 29, 2021 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cosven cosven cosven approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mahjonp @cosven