Skip to content

tpcc: add wait times on each transactions#42

Merged
mahjonp merged 4 commits intomasterfrom
wait_times
May 21, 2020
Merged

tpcc: add wait times on each transactions#42
mahjonp merged 4 commits intomasterfrom
wait_times

Conversation

@mahjonp
Copy link
Copy Markdown
Collaborator

@mahjonp mahjonp commented May 20, 2020 •
edited
Loading

Add Keying Time and Thinking Time between txn execution and two flags.

Usage:
  go-tpc tpcc run [flags]

Flags:
  -h, --help   help for run
      --wait   including keying & thinking time described on TPC-C Standard Specification

For example.

./bin/go-tpc tpcc --warehouses 4 run --wait

mahjonp added 2 commits May 20, 2020 19:54
@mahjonp
tpcc: add wait times
9543375 
Signed-off-by: mahjonp <junpeng.man@gmail.com>
@mahjonp
update README
37df1d1 
Signed-off-by: mahjonp <junpeng.man@gmail.com>
@mahjonp mahjonp requested review from coocood and zhouqiang-cl May 20, 2020 12:10
@mahjonp
replace 95th percentile to 90th percentile
043fb15 
Signed-off-by: mahjonp <junpeng.man@gmail.com>
@zhouqiang-cl zhouqiang-cl requested a review from innerr May 20, 2020 12:47
@siddontang
Copy link
Copy Markdown
Member

siddontang commented May 21, 2020

I can't understand keying and thinking easily, can you use other words or refer to other TPCC implementation at first then think a better name?

@coocood
Copy link
Copy Markdown
Member

coocood commented May 21, 2020

LGTM

@mahjonp
address comments
347d9d2 
Signed-off-by: mahjonp <junpeng.man@gmail.com>
@mahjonp
Copy link
Copy Markdown
Collaborator Author

mahjonp commented May 21, 2020

I can't understand keying and thinking easily, can you use other words or refer to other TPCC implementation at first then think a better name?

I combined them into one wait flag.

zhouqiang-cl
zhouqiang-cl approved these changes May 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahjonp mahjonp merged commit 3ed127b into master May 21, 2020
@mahjonp mahjonp deleted the wait_times branch May 21, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coocood coocood Awaiting requested review from coocood

@innerr innerr Awaiting requested review from innerr

1 more reviewer

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mahjonp @siddontang @coocood @zhouqiang-cl