fix: set tidb tunning variables only when connected to valid tidb#188
Merged
Yui-Song merged 8 commits intopingcap:masterfrom Feb 26, 2025
Merged
fix: set tidb tunning variables only when connected to valid tidb#188Yui-Song merged 8 commits intopingcap:masterfrom
Yui-Song merged 8 commits intopingcap:masterfrom
Conversation
|
|
Contributor
Author
|
@zanmato1984 |
zanmato1984
reviewed
Feb 24, 2025
zanmato1984
reviewed
Feb 25, 2025
Co-authored-by: Rossi Sun <zanmato1984@gmail.com>
…nto yuchao/fix_tidb_tunning
zanmato1984
approved these changes
Feb 26, 2025
Contributor
zanmato1984
left a comment
There was a problem hiding this comment.
Besides those two nits. This LGTM.
Contributor
|
I think it's good to go now. |
Yui-Song
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number: close #187
According to System Variables | TiDB Docs, set TiDB QueryTuningVars only when connected to TiDB(>=7.1.0).
It's still a rough comparison to quickly fix the compatibility issue.